[bootlin/training-materials updates] master: slides/kernel-driver-development: fix wrong wait-event diagram (6b0601c7)
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Wed Apr 19 17:07:15 CEST 2023
Repository : https://github.com/bootlin/training-materials
On branch : master
Link : https://github.com/bootlin/training-materials/commit/6b0601c714620d2a65c73d57cf3060f533509870
>---------------------------------------------------------------
commit 6b0601c714620d2a65c73d57cf3060f533509870
Author: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Date: Wed Apr 19 17:07:15 2023 +0200
slides/kernel-driver-development: fix wrong wait-event diagram
The diagram has always been wrong. When we're woken up from sleeping,
we're not calling wait_event() again: the loop is *inside*
wait_event().
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
>---------------------------------------------------------------
6b0601c714620d2a65c73d57cf3060f533509870
.../wait-event.dia | 121 ++++++++++-----------
1 file changed, 58 insertions(+), 63 deletions(-)
diff --git a/slides/kernel-driver-development-sleeping/wait-event.dia b/slides/kernel-driver-development-sleeping/wait-event.dia
index 731956a6..103fff81 100644
--- a/slides/kernel-driver-development-sleeping/wait-event.dia
+++ b/slides/kernel-driver-development-sleeping/wait-event.dia
@@ -142,7 +142,7 @@
<dia:point val="7,6"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="5.00625,5.62625;8.99375,6.37375"/>
+ <dia:rectangle val="5.26875,5.53184;8.73125,6.46816"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -156,7 +156,7 @@
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="7,6.22125"/>
+ <dia:point val="7,6.2704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -207,7 +207,7 @@
<dia:point val="7,10"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="3.06859,9.19822;10.9501,10.8018"/>
+ <dia:rectangle val="3.08875,9.13184;10.9112,10.8682"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -222,7 +222,7 @@ TASK_UNINTERRUPTIBLE#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="7,9.81191"/>
+ <dia:point val="7,9.8704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -244,7 +244,7 @@ TASK_UNINTERRUPTIBLE#</dia:string>
<dia:point val="7,15"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="5.52,14.2263;8.48,15.7737"/>
+ <dia:rectangle val="5.775,14.1318;8.225,15.8682"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -259,7 +259,7 @@ condition#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="7,14.8213"/>
+ <dia:point val="7,14.8704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -310,7 +310,7 @@ condition#</dia:string>
<dia:point val="7,2"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="3.33531,1.22625;10.6647,2.77375"/>
+ <dia:rectangle val="3.49625,1.13184;10.5038,2.86816"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -325,7 +325,7 @@ state#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="7,1.82125"/>
+ <dia:point val="7,1.8704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -487,7 +487,7 @@ state#</dia:string>
<dia:point val="19,15"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="17.315,14.6263;20.685,15.3738"/>
+ <dia:rectangle val="17.6288,14.5318;20.3712,15.4682"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -501,7 +501,7 @@ state#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="19,15.2213"/>
+ <dia:point val="19,15.2704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -553,7 +553,7 @@ state#</dia:string>
<dia:point val="7,24"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="3.89922,23.6262;10.1008,24.3737"/>
+ <dia:rectangle val="4.44375,23.5318;9.55625,24.4682"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -567,7 +567,7 @@ state#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="7,24.2212"/>
+ <dia:point val="7,24.2704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -619,7 +619,7 @@ state#</dia:string>
<dia:point val="7,20"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="4.40813,19.2263;9.59187,20.7737"/>
+ <dia:rectangle val="4.57375,19.1318;9.42625,20.8682"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -634,7 +634,7 @@ TASK_RUNNING#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="7,19.8212"/>
+ <dia:point val="7,19.8704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -737,13 +737,13 @@ TASK_RUNNING#</dia:string>
</dia:object>
<dia:object type="Standard - Box" version="0" id="O21">
<dia:attribute name="obj_pos">
- <dia:point val="15,5"/>
+ <dia:point val="15,9"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="14.95,4.95;23.05,7.05"/>
+ <dia:rectangle val="14.95,8.95;23.05,11.05"/>
</dia:attribute>
<dia:attribute name="elem_corner">
- <dia:point val="15,5"/>
+ <dia:point val="15,9"/>
</dia:attribute>
<dia:attribute name="elem_width">
<dia:real val="8"/>
@@ -766,10 +766,10 @@ TASK_RUNNING#</dia:string>
</dia:object>
<dia:object type="Standard - Text" version="1" id="O22">
<dia:attribute name="obj_pos">
- <dia:point val="19,6"/>
+ <dia:point val="19,10"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="16.465,5.22625;21.535,6.77375"/>
+ <dia:rectangle val="16.9163,9.13184;21.0838,10.8682"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -784,7 +784,7 @@ wake_up()#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="19,5.82125"/>
+ <dia:point val="19,9.8704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -806,11 +806,11 @@ wake_up()#</dia:string>
<dia:point val="19,14"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="18.6382,6.8882;19.3618,14.05"/>
+ <dia:rectangle val="18.6382,10.8882;19.3618,14.05"/>
</dia:attribute>
<dia:attribute name="conn_endpoints">
<dia:point val="19,14"/>
- <dia:point val="19,7"/>
+ <dia:point val="19,11"/>
</dia:attribute>
<dia:attribute name="numcp">
<dia:int val="1"/>
@@ -837,7 +837,7 @@ wake_up()#</dia:string>
<dia:point val="22,11"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="20.6137,10.6263;23.3863,11.3738"/>
+ <dia:rectangle val="20.895,10.5318;23.105,11.4682"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -851,7 +851,7 @@ wake_up()#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="22,11.2213"/>
+ <dia:point val="22,11.2704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -865,45 +865,12 @@ wake_up()#</dia:string>
<dia:enum val="2"/>
</dia:attribute>
</dia:object>
- <dia:object type="Standard - ZigZagLine" version="1" id="O25">
- <dia:attribute name="obj_pos">
- <dia:point val="19,5"/>
- </dia:attribute>
- <dia:attribute name="obj_bb">
- <dia:rectangle val="10.8882,1.6382;19.05,5.05"/>
- </dia:attribute>
- <dia:attribute name="orth_points">
- <dia:point val="19,5"/>
- <dia:point val="19,2"/>
- <dia:point val="11,2"/>
- </dia:attribute>
- <dia:attribute name="orth_orient">
- <dia:enum val="1"/>
- <dia:enum val="0"/>
- </dia:attribute>
- <dia:attribute name="autorouting">
- <dia:boolean val="true"/>
- </dia:attribute>
- <dia:attribute name="end_arrow">
- <dia:enum val="22"/>
- </dia:attribute>
- <dia:attribute name="end_arrow_length">
- <dia:real val="0.5"/>
- </dia:attribute>
- <dia:attribute name="end_arrow_width">
- <dia:real val="0.5"/>
- </dia:attribute>
- <dia:connections>
- <dia:connection handle="0" to="O21" connection="1"/>
- <dia:connection handle="1" to="O6" connection="4"/>
- </dia:connections>
- </dia:object>
- <dia:object type="Standard - Text" version="1" id="O26">
+ <dia:object type="Standard - Text" version="1" id="O25">
<dia:attribute name="obj_pos">
<dia:point val="13,16"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="12.2387,15.6263;13.7613,16.3738"/>
+ <dia:rectangle val="12.4075,15.5318;13.5925,16.4682"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -917,7 +884,7 @@ wake_up()#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="13,16.2213"/>
+ <dia:point val="13,16.2704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -931,12 +898,12 @@ wake_up()#</dia:string>
<dia:enum val="2"/>
</dia:attribute>
</dia:object>
- <dia:object type="Standard - Text" version="1" id="O27">
+ <dia:object type="Standard - Text" version="1" id="O26">
<dia:attribute name="obj_pos">
<dia:point val="9,18"/>
</dia:attribute>
<dia:attribute name="obj_bb">
- <dia:rectangle val="8.34375,17.6262;9.65625,18.3737"/>
+ <dia:rectangle val="8.4675,17.5318;9.5325,18.4682"/>
</dia:attribute>
<dia:attribute name="text">
<dia:composite type="text">
@@ -950,7 +917,7 @@ wake_up()#</dia:string>
<dia:real val="0.80000000000000004"/>
</dia:attribute>
<dia:attribute name="pos">
- <dia:point val="9,18.2212"/>
+ <dia:point val="9,18.2704"/>
</dia:attribute>
<dia:attribute name="color">
<dia:color val="#000000"/>
@@ -964,5 +931,33 @@ wake_up()#</dia:string>
<dia:enum val="2"/>
</dia:attribute>
</dia:object>
+ <dia:object type="Standard - Line" version="0" id="O27">
+ <dia:attribute name="obj_pos">
+ <dia:point val="14.9512,10"/>
+ </dia:attribute>
+ <dia:attribute name="obj_bb">
+ <dia:rectangle val="10.8882,9.6382;15.0012,10.3618"/>
+ </dia:attribute>
+ <dia:attribute name="conn_endpoints">
+ <dia:point val="14.9512,10"/>
+ <dia:point val="11,10"/>
+ </dia:attribute>
+ <dia:attribute name="numcp">
+ <dia:int val="1"/>
+ </dia:attribute>
+ <dia:attribute name="end_arrow">
+ <dia:enum val="22"/>
+ </dia:attribute>
+ <dia:attribute name="end_arrow_length">
+ <dia:real val="0.5"/>
+ </dia:attribute>
+ <dia:attribute name="end_arrow_width">
+ <dia:real val="0.5"/>
+ </dia:attribute>
+ <dia:connections>
+ <dia:connection handle="0" to="O21" connection="8"/>
+ <dia:connection handle="1" to="O3" connection="4"/>
+ </dia:connections>
+ </dia:object>
</dia:layer>
</dia:diagram>
More information about the training-materials-updates
mailing list