[bootlin/training-materials updates] master: labs/kernel-serial-output: clarify usage of devm_kasprintf() (c5ab7e7d)

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Apr 19 16:45:04 CEST 2023


Repository : https://github.com/bootlin/training-materials
On branch  : master
Link       : https://github.com/bootlin/training-materials/commit/c5ab7e7d065ed0b89894ba80a3a523395235c3c7

>---------------------------------------------------------------

commit c5ab7e7d065ed0b89894ba80a3a523395235c3c7
Author: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Date:   Wed Apr 19 16:44:05 2023 +0200

    labs/kernel-serial-output: clarify usage of devm_kasprintf()
    
    People were confused about the example code provided as it wasn't
    doing anything with the return value of devm_kasprintf().
    
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>


>---------------------------------------------------------------

c5ab7e7d065ed0b89894ba80a3a523395235c3c7
 labs/kernel-serial-output/kernel-serial-output.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/labs/kernel-serial-output/kernel-serial-output.tex b/labs/kernel-serial-output/kernel-serial-output.tex
index 968ab5e9..24e27c5a 100644
--- a/labs/kernel-serial-output/kernel-serial-output.tex
+++ b/labs/kernel-serial-output/kernel-serial-output.tex
@@ -69,7 +69,7 @@ struct resource *res;
 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 /* Error handling */
 [...]
-devm_kasprintf(&pdev->dev, GFP_KERNEL, "serial-%x", res->start);
+name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "serial-%x", res->start);
   \end{verbatim}
   \kfunc{devm_kasprintf} allocates a buffer and runs \kfunc{kasprintf}
   to fill its contents. \kfunc{platform_get_resource} is used to




More information about the training-materials-updates mailing list