[bootlin/training-materials updates] master: labs/kernel-i2c-describing-hardware: slightly rephrase the LEDs lab (00cd135b)

Miquel Raynal miquel.raynal at bootlin.com
Tue Apr 18 10:54:34 CEST 2023


Repository : https://github.com/bootlin/training-materials
On branch  : master
Link       : https://github.com/bootlin/training-materials/commit/00cd135b441ea7387b1db884246a5915306f3351

>---------------------------------------------------------------

commit 00cd135b441ea7387b1db884246a5915306f3351
Author: Miquel Raynal <miquel.raynal at bootlin.com>
Date:   Tue Apr 18 10:54:22 2023 +0200

    labs/kernel-i2c-describing-hardware: slightly rephrase the LEDs lab
    
    Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>


>---------------------------------------------------------------

00cd135b441ea7387b1db884246a5915306f3351
 .../kernel-i2c-describing-hardware.tex                    | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/labs/kernel-i2c-describing-hardware/kernel-i2c-describing-hardware.tex b/labs/kernel-i2c-describing-hardware/kernel-i2c-describing-hardware.tex
index 5839ae5d..07e3320e 100644
--- a/labs/kernel-i2c-describing-hardware/kernel-i2c-describing-hardware.tex
+++ b/labs/kernel-i2c-describing-hardware/kernel-i2c-describing-hardware.tex
@@ -84,13 +84,14 @@ You should now see one of the LEDs blink with the CPU activity, the
 others remain off. If you look at the bindings documents
 \kfile{Documentation/devicetree/bindings/leds/common.yaml} and
 \kfile{Documentation/devicetree/bindings/leds/leds-gpio.yaml}, you'll
-notice we can easily tweak the \code{default-state} in order to try
-forcing the default state.
-
-You will need to modify a core file in order to do that. But because we
-do not want to mess with a shared file, we might instead add a label to
-the node describing the LED we want to turn on and reference this new
-label in our custom DTS.
+notice we can tweak the \code{default-state} in order to make the
+three inactive user LEDs bright.
+
+You will need to modify a shared DTSI file in order to do that. But
+because we do not want to impact other boards also using that same DTSI
+file, we might instead add a label to the \code{leds} container node. We
+could then reference this new label in our custom DTS and overwrite the
+\code{default-state} property of each LED subnode.
 
 Reboot the board using the new DTS and observe the LEDs default states
 change, except one of them which will not turn on. It is expected. If




More information about the training-materials-updates mailing list