[bootlin/training-materials updates] master: kernel-frameworks: Fix test on register_framebuffer (301df06c)

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Oct 29 10:46:40 CEST 2021


Repository : https://github.com/bootlin/training-materials
On branch  : master
Link       : https://github.com/bootlin/training-materials/commit/301df06cd89b4b56bf28aacadcdef4e4bbad8809

>---------------------------------------------------------------

commit 301df06cd89b4b56bf28aacadcdef4e4bbad8809
Author: Gregory CLEMENT <gregory.clement at bootlin.com>
Date:   Fri Sep 10 15:42:11 2021 +0200

    kernel-frameworks: Fix test on register_framebuffer
    
    Negative value means an error not the opposite.
    
    Reported-by: Trevor Woerner
    Signed-off-by: Gregory CLEMENT <gregory.clement at bootlin.com>


>---------------------------------------------------------------

301df06cd89b4b56bf28aacadcdef4e4bbad8809
 slides/kernel-frameworks2/kernel-frameworks2.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/slides/kernel-frameworks2/kernel-frameworks2.tex b/slides/kernel-frameworks2/kernel-frameworks2.tex
index 75411805..bbdae286 100644
--- a/slides/kernel-frameworks2/kernel-frameworks2.tex
+++ b/slides/kernel-frameworks2/kernel-frameworks2.tex
@@ -357,7 +357,7 @@ static int xxxfb_probe (struct pci_dev *dev, const struct pci_device_id *ent)
     [...]
     info->fbops = &xxxfb_ops;
     [...]
-    if (register_framebuffer(info) > 0)
+    if (register_framebuffer(info) < 0)
         return -EINVAL;
     [...]
 }




More information about the training-materials-updates mailing list